Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

カスタム絵文字のライセンスを一括でできるように #10671

Merged
merged 4 commits into from
Apr 18, 2023

Conversation

nenohi
Copy link
Contributor

@nenohi nenohi commented Apr 18, 2023

What

カスタム絵文字に関するライセンスの付与を選択モードより一括でセットできるようにした

Why

#10655 より、絵文字管理をやりやすくするため

Additional info (optional)

ローカル環境にてテスト済み

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR labels Apr 18, 2023
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #10671 (3fdb448) into develop (471b836) will decrease coverage by 0.62%.
The diff coverage is 72.88%.

@@             Coverage Diff             @@
##           develop   #10671      +/-   ##
===========================================
- Coverage    76.12%   75.50%   -0.62%     
===========================================
  Files          899      735     -164     
  Lines        88777    68576   -20201     
  Branches      6253     5947     -306     
===========================================
- Hits         67580    51778   -15802     
+ Misses       21197    16798    -4399     
Impacted Files Coverage Δ
packages/backend/src/core/CustomEmojiService.ts 32.33% <12.50%> (-1.00%) ⬇️
...rver/api/endpoints/admin/emoji/set-license-bulk.ts 94.59% <94.59%> (ø)
packages/backend/src/server/api/EndpointsModule.ts 100.00% <100.00%> (ø)
packages/backend/src/server/api/endpoints.ts 100.00% <100.00%> (ø)

... and 166 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@syuilo syuilo merged commit 65ff2c2 into misskey-dev:develop Apr 18, 2023
@syuilo
Copy link
Member

syuilo commented Apr 18, 2023

👍

nenohi added a commit to nenohi/misskey that referenced this pull request Apr 20, 2023
syuilo added a commit that referenced this pull request Apr 20, 2023
* ロールタイムライン設定

* isRoleTimeline to isExplorable

* ポリシーではないので削除

* 型からも

* wip

* 足りてなかった説

* wip

* listはpublicを表示

* 前回の記載修正( #10671 )

---------

Co-authored-by: syuilo <[email protected]>
sasagar pushed a commit to sasagar/misskey that referenced this pull request May 9, 2023
* ロールタイムライン設定

* isRoleTimeline to isExplorable

* ポリシーではないので削除

* 型からも

* wip

* 足りてなかった説

* wip

* listはpublicを表示

* 前回の記載修正( misskey-dev#10671 )

---------

Co-authored-by: syuilo <[email protected]>
na2na-p pushed a commit to na2na-p/misskey that referenced this pull request May 10, 2023
* setlicensebulk追加

* 5時に誤字った!w

* 並び順の変更(set,add,removeの順

* add changelog
na2na-p pushed a commit to na2na-p/misskey that referenced this pull request May 10, 2023
* ロールタイムライン設定

* isRoleTimeline to isExplorable

* ポリシーではないので削除

* 型からも

* wip

* 足りてなかった説

* wip

* listはpublicを表示

* 前回の記載修正( misskey-dev#10671 )

---------

Co-authored-by: syuilo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants